[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn diff fix for bug 2044

From: Johan Corveleyn <jcorvel_at_gmail.com>
Date: Tue, 19 Mar 2013 21:42:26 +0100

On Tue, Mar 19, 2013 at 8:56 PM, Gabriela Gibson
<gabriela.gibson_at_gmail.com> wrote:
> On 19/03/13 13:09, Julian Foad wrote:
>
> Julian Foad wrote:
>
>> For the record, the summary line of issue #2044 is 'Fully customizable
>> external diff invocations'. (I like to mention the summary alongside
>> the number as I am not good at memorizing issue numbers.) I'm curious
>> about your patch because I am interested in issue #2044 and would like
>> to see how this particular change would fit in.
>>
>> Please could you tell me more precisely what your patch does and why?
>> Of course I could read carefully through your patch to discover the
>> 'what', but not the 'why'.
>
> Hi Julian,
>
> It's not really a patch as such, not yet anyway :> Also, this strictly
> speaking is issue 2074, which was marked as a duplicate of 2044 since it
> partially solves 2074.

Not really about the content of your patch, but I thought I'd
reiterate what Julian said (I feel the same way): please always add
the issue summary when you mention an issue number (both in mails and
in commit messages). Personally I usually do this "inline", so I would
type:

"Also, this strictly speaking is issue 2074 (issue summary goes here),
which was marked as a duplicate of 2044 (other issue summary goes
here), since it partially solves 2074".

Of course, since the summary of 2044 is already mentioned earlier in
the thread, there's no need to repeat it, I'm just giving a typical
example ...

There are other variations, depending on your preference, whether or
not you think it breaks the flow of you sentence, ... (e.g. I also
often just add a footnote marker after the issue number [1], and add
both the link to the issue-tracker (so people can simply click on it)
and the summary in the footnote). The important thing is that the
information is there, and people don't have to go look up the
information just to understand what your email is about.

[1] http://subversion.tigris.org/issues/show_bug.cgi?id=2074
(--extensions '' doesn't work.)

Just my 2 cents ...

-- 
Johan
Received on 2013-03-19 21:43:18 CET

This is an archived mail posted to the Subversion Dev mailing list.