[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Windows build still requires apr-util?

From: Sergei Antonov <saproj_at_gmail.com>
Date: Thu, 14 Mar 2013 13:32:32 +0100

On 13 March 2013 19:15, Bert Huijben <bert_at_qqmail.nl> wrote:
>
>
>> -----Original Message-----
>> From: Sergei Antonov [mailto:saproj_at_gmail.com]
>> Sent: woensdag 13 maart 2013 18:47
>> To: dev_at_subversion.apache.org
>> Subject: Re: Windows build still requires apr-util?
>>
>> Gentle reminder: VS 2010 doesn't compile the latest revision.
>> Please, add "#include <time.h>" into
>> subversion\libsvn_subr\win32_crashrpt.c and commit.
>
> I think that is somehow dependant on other settings as it just compiles for me with 2010 (and 2012 and 2008).

Do you compile this file at all?

> Can you explain what makes your environment different

You do not have SVN_USE_WIN32_CRASHHANDLER?
You use different revision? (mine is 1456399)

Open VS 2010 .sln, navigate to 'win32_crashrpt.c' in project
'libsvn_subr', choose Build->Compile. What do you see? I see this:

1>------ Build started: Project: libsvn_subr (Libraries\libsvn_subr),
Configuration: Debug Win32 ------
1>Build started 14.03.2013 13:26:47.
1>ClCompile:
1> win32_crashrpt.c
1>..\..\..\subversion\libsvn_subr\win32_crashrpt.c(706): error C4013:
'time' undefined; assuming extern returning int
1>..\..\..\subversion\libsvn_subr\win32_crashrpt.c(707): error C4013:
'strftime' undefined; assuming extern returning int
1>..\..\..\subversion\libsvn_subr\win32_crashrpt.c(707): error C4013:
'localtime' undefined; assuming extern returning int

1>
1>Build FAILED.
1>
1>Time Elapsed 00:00:00.96
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

> , because just adding includes everywhere is not the way to fix these things

Every translation unit with a call to localtime/time/strftime must
include time.h. So it IS a way to fix these things.
Received on 2013-03-14 13:33:10 CET

This is an archived mail posted to the Subversion Dev mailing list.