Re: [PATCH] Allow building with g++
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 12 Mar 2013 14:57:14 +0000 (GMT)
Philip Martin wrote:
> Philip Martin <philip_at_codematters.co.uk> writes:
+1.† Good idea and not too ugly.
I scanned through the patch and there are just two bits I find a bit ugly -- s/private/privat/ and s/template/templat/ -- and that's only my subjective language preference.
Since the type of 'private' is id_private_t, I would suggest either 'id_private' or 'id' would make sense for a new name.† Not sure about 'template'.
>> None of the changes affect Subversion's public API.
That sounds correct to me.
This is an archived mail posted to the Subversion Dev mailing list.