[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Allow building with g++

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Tue, 12 Mar 2013 14:57:14 +0000 (GMT)

Philip Martin wrote:

> Philip Martin <philip_at_codematters.co.uk> writes:
>> What do people think?† Good idea?† Too ugly for the limited benefit?

+1.† Good idea and not too ugly.

I scanned through the patch and there are just two bits I find a bit ugly -- s/private/privat/ and s/template/templat/ -- and that's only my subjective language preference.

Since the type of 'private' is id_private_t, I would suggest either 'id_private' or 'id' would make sense for a new name.† Not sure about 'template'.

>> None of the changes affect Subversion's public API.
>
> Oops!† Looking at the log I see that this bit does change the API:
>
>> * subversion/include/svn_ra_svn.h
>> † (enum svn_ra_svn_item_kind_t): New, replaces enum nested in
>> † † struct svn_ra_svn_item_t.
>
> I think that change is backward compatible for C.† The enum identifiers
> are already global in C.† It is changing the type of svn_ra_svn_item_t
> but only replacing one enum with another.

That sounds correct to me.

- Julian
Received on 2013-03-12 18:37:15 CET

This is an archived mail posted to the Subversion Dev mailing list.