[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Allow building with g++

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 12 Mar 2013 15:51:55 +0000

Julian Foad <julianfoad_at_btopenworld.com> writes:

> Philip Martin wrote:
>
>> Philip Martin <philip_at_codematters.co.uk> writes:
>>> What do people think?  Good idea?  Too ugly for the limited benefit?
>
> +1.  Good idea and not too ugly.
>
> I scanned through the patch and there are just two bits I find a bit
> ugly -- s/private/privat/ and s/template/templat/ -- and that's only
> my subjective language preference.

Agreed. I didn't attempt to think up a good replacement.

> Since the type of 'private' is id_private_t, I would suggest either
> 'id_private' or 'id' would make sense for a new name.  Not sure about
> 'template'.

The 'private' usage in serf is not an id_private_t, it's a generic void
pointer to some unknown struct.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2013-03-12 18:36:51 CET

This is an archived mail posted to the Subversion Dev mailing list.