[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Weird 'svn diff' operation with --old/--new (was: Re: FreeBSD project and subversion.)

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 8 Feb 2013 01:59:50 +0000 (GMT)

Alexey Neyman wrote:
> Julian Foad wrote:
>> Alexey Neyman wrote:
>> > I noticed a weird behavior of 'svn diff --old=... --new=...' where
>> > reversing the old/new targets does not produce the reverse diff, as
>> > one would expect.
> [[[
> Make 'svn diff --old=FOO --new=BAR default to WORKING revision for old target
> if new target is explicitly specified, so that it is the reverse diff from 'svn diff --old=BAR --new=FOO'.

> * subversion/svn/diff-cmd.c
> (svn_cl__diff) Change defaults as described and simplify the logic.
> ]]]

Thanks -- I think this all looks good.

Committed in 1443821, with just some minor editing of the comment.

(Incidentally, applying your patch using 'svn patch' led me to discover a bug in 'svn patch' which I have just emailed about.)

- Julian
Received on 2013-02-08 03:00:28 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.