[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Weird 'svn diff' operation with --old/--new (was: Re: FreeBSD project and subversion.)

From: Alexey Neyman <stilor_at_att.net>
Date: Thu, 07 Feb 2013 08:55:33 -0800

Hi Julian,

On Thursday, February 07, 2013 04:00:49 PM Julian Foad wrote:
> Alexey Neyman wrote:
> > [Cross-posting to dev@ for patch review]
> > I noticed a weird behavior of 'svn diff --old=... --new=...' where
> > reversing the old/new targets does not produce the reverse diff, as
> > one would expect.
>
> Hi Alexey. Thanks for the report. As you pointed out, I changed something
> in this area recently, so I'll take a closer look and fix it. I haven't
> done so yet but should get to it in the next day or two.
>
> [...]

Thanks!

[... snip ...]

> > [[[
> > Make svn diff --old=.. --new=.. default to WORKING revision for old target
> > if new target is explicitly specified.
>
> A log message should always indicate *why* the change was made.

Hope this is better:

[[[
Make 'svn diff --old=FOO --new=BAR default to WORKING revision for old target
if new target is explicitly specified, so that it is the reverse diff from
'svn diff --old=BAR --new=FOO'.

* subversion/svn/diff-cmd.c
 (svn_cl__diff) Change defaults as described and simplify the logic.
]]]

Regards,
Alexey.
Received on 2013-02-07 17:56:14 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.