If it helps, here's a last try:
- wrapped the 3 long lines to 80 columns
- PEP8 fixes (only on these 3 lines), such as removed space after "{",
before ":", before "}"
The only PEP8 violation that remain on these lines is "continuation
line under-indented for visual indent"
I don't know how to format best, please do as you see fit.
Cheers,
Janos
On Sun, Jan 27, 2013 at 3:43 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
>> Index: tools/hook-scripts/mailer/mailer.py
>> ===================================================================
>> --- tools/hook-scripts/mailer/mailer.py (revision 1438886)
>> +++ tools/hook-scripts/mailer/mailer.py (working copy)
>> @@ -98,7 +98,7 @@ def main(pool, cmd, config_fname, repos_dir, cmd_a
>> if cmd == 'commit':
>> revision = int(cmd_args[0])
>> repos = Repository(repos_dir, revision, pool)
>> - cfg = Config(config_fname, repos, { 'author' : repos.author })
>> + cfg = Config(config_fname, repos, { 'author' : repos.author, 'repodir' : os.path.basename(repos.repos_dir) })
>
> My only comment is that these lines should be wrapped to 80 columns.
>
> I'll hold off on committing, though, to let others have a look too.
>
> Thanks for the patch,
>
> Daniel
--
Janos Gyerik
http://www.janosgyerik.com/
https://twitter.com/janosgyerik/
Received on 2013-01-27 16:03:00 CET