[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] minor change to mailer.py for subject formatting

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 27 Jan 2013 16:43:54 +0200

> Index: tools/hook-scripts/mailer/mailer.py
> ===================================================================
> --- tools/hook-scripts/mailer/mailer.py (revision 1438886)
> +++ tools/hook-scripts/mailer/mailer.py (working copy)
> @@ -98,7 +98,7 @@ def main(pool, cmd, config_fname, repos_dir, cmd_a
> if cmd == 'commit':
> revision = int(cmd_args[0])
> repos = Repository(repos_dir, revision, pool)
> - cfg = Config(config_fname, repos, { 'author' : repos.author })
> + cfg = Config(config_fname, repos, { 'author' : repos.author, 'repodir' : os.path.basename(repos.repos_dir) })

My only comment is that these lines should be wrapped to 80 columns.

I'll hold off on committing, though, to let others have a look too.

Thanks for the patch,

Daniel
Received on 2013-01-27 15:44:42 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.