[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] code file names linkified in general.html of the Hacking Gttuide

From: Gabriela Gibson <gabriela.gibson_at_gmail.com>
Date: Thu, 20 Dec 2012 21:05:39 +0000

On 19/12/12 12:59, Stefan Sperling wrote:
> Here it looks like we'll end up closing <li> twice. Was that on purpose?

Oops :( -- Firefox saved a mangled original I worked on and when I
looked at the messy patch this produced, I decided to get a fresh copy
and to 'buff it out' by copying the changes manually from the broken
copy and thus I introduced this error.

Most of this would not have happened if I had svn protection here I
guess -- would it be worthwhile to add the html part of the project to
the revision tree?

Network access isn't always a givens and the guide is a key document,
it'll be nice to have in the /doc dir.

As an aside, Lynx also saves a a bad copy. I didn't expect that -- 10
years ago this all worked just fine! :o)

> I haven't checked all other tags for similar errors, not enough time.
> It might be a good idea to run an XHTML validator on the modified file.

It might be useful to add the info of how to submit web pages patches to
the the 'log messages' section of the guide
for example:

When writing log messages for patches regarding the project's web pages, eg:


list the names of files modified in the patch in the log message,
relative to site/publication and list anchors of sections added or
modified like this:

* docs/community-guide/some_page.html
   (section-name): fixed issue xyz

Please validate the new hmtl file with a XHTML validator and check all
the links before submitting the patch.

(Optional: Please use wget to download an uncorrupted original to modify
instead of a copy saved by your browser.)

David Shahaf wrote:

> I'd say link to APR 1.5.x, which is the current release in the 1.x
> series:
http://svn.apache.org/repos/asf/apr/apr/branches/1.5.x/include> /apr_pools.h

If it generates a continuous liability maybe this part is best left
untouched, or perhaps preserved in a static file?
Received on 2012-12-20 22:06:10 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.