[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] code file names linkified in general.html of the Hacking Guide

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 19 Dec 2012 13:59:26 +0100

On Wed, Dec 19, 2012 at 12:40:42PM +0000, Gabriela Gibson wrote:
> [[[
> Linkified code file names in file general.htm of the Hacking Guide
>
> Converted file names into links pointing to the current revision on page:
>
> http://subversion.apache.org/docs/community-guide/general.html#code-to-read
>
> Converted directory names into links pointing to the current revision on
> page:
>
> http://subversion.apache.org/docs/community-guide/general.html#directory-layout
>
> Patch by: Gabriela Gibson <gabriela.gibson_at_gmail.com>
> ]]]
>

Can you please list the names of files you're modifying in the patch
in the log message? We usually list them relative to site/publish and
list anchors of sections modified like this:

* docs/community-guide/general.html
  (code-to-read): Linkified code file names.

and so on. This formatting matches what is used for code contributions
and makes the actual change description stand out better.

> --- general-orig.html 2012-12-19 11:53:49.880600246 +0000
> +++ general-new.html 2012-12-19 12:22:42.253190871 +0000

> Stuff that works with Subversion, but that Subversion doesn't
> depend on, and that is maintained by individuals who may or may
> not participate in Subversion development. Code in contrib/ is
> open source, but may have a different license or copyright holder
> than Subversion itself.</p>
> </li>
> -<li><p><tt>packages/</tt><br>
> +</li>

Here it looks like we'll end up closing <li> twice. Was that on purpose?
I haven't checked all other tags for similar errors, not enough time.
It might be a good idea to run an XHTML validator on the modified file.
Received on 2012-12-19 14:00:14 CET

This is an archived mail posted to the Subversion Dev mailing list.