[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for "\r" in "svnrdump load" (issue 4263) (reworked)

From: Ben Reser <ben_at_reser.org>
Date: Tue, 18 Dec 2012 11:20:03 -0800

On Tue, Dec 18, 2012 at 9:17 AM, Gabriela Gibson
<gabriela.gibson_at_gmail.com> wrote:
> [[[
> Fix issue #4263: svnrdump: E125005: Cannot accept non-LF line endings in
> 'svn:log' property
>
> Fix to ensure that no "\r" characters are present in revision or node
> props.
>
> In the case of "\r\n" character sequences, the "\r" is removed.
>
> In the case of "\r" characters which are not followed by "\n", the "\r"
> is replaced by a "\n" character.
>
> * subversion/svnrdump/svnrdump.h:
> (svn_rdump__normalize_prop): New function declaration.
>
> * subversion/svnrdump/util.c:
> (svn_rdump__normalize_prop): New function to allow "svnrdump load" to
> use existing logic
> (svn_rdump__normalize_props): Refactored to move logic into
> svn_rdump__normalize_prop()
>
> * subversion/svnrdump/load_editor.c:
> (set_revision_property): Added call to svn_rdump__normalize_prop()
> (set_node_property): Added call to svn_rdump__normalize_prop()
>
> * subversion/tests/cmdline/svnrdump_tests.py:
> (copy_bad_line_endings_load): Removed "XFail" decorator
>
> ]]]

Thanks, committed in r1423585, only thing I added was the Patch by:
line to the log to credit you.
Received on 2012-12-18 20:20:46 CET

This is an archived mail posted to the Subversion Dev mailing list.