[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for "\r" in "svnrdump load" (issue 4263) (reworked)

From: Gabriela Gibson <gabriela.gibson_at_gmail.com>
Date: Tue, 18 Dec 2012 17:17:15 +0000

Fix issue #4263: svnrdump: E125005: Cannot accept non-LF line endings in
'svn:log' property

Fix to ensure that no "\r" characters are present in revision or node

In the case of "\r\n" character sequences, the "\r" is removed.

In the case of "\r" characters which are not followed by "\n", the "\r"
is replaced by a "\n" character.

* subversion/svnrdump/svnrdump.h:
    (svn_rdump__normalize_prop): New function declaration.

* subversion/svnrdump/util.c:
    (svn_rdump__normalize_prop): New function to allow "svnrdump load" to
      use existing logic
    (svn_rdump__normalize_props): Refactored to move logic into

* subversion/svnrdump/load_editor.c:
    (set_revision_property): Added call to svn_rdump__normalize_prop()
    (set_node_property): Added call to svn_rdump__normalize_prop()

* subversion/tests/cmdline/svnrdump_tests.py:
    (copy_bad_line_endings_load): Removed "XFail" decorator


Received on 2012-12-18 18:17:48 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.