On 14.12.2012 02:32, Hyrum K Wright wrote:
> On Thu, Dec 13, 2012 at 1:13 PM, Branko Čibej <brane_at_wandisco.com> wrote:
>
>> The attached patch makes several changes to how we discover compilers
>> and set flags on *nix:
>>
>> * Search for clang as well as the default gcc/cc, and prefer clang(++)
>> over gcc/g++.
>> * Set standards-compliance mode (C90/C++11) even without maintainer-mode.
>>
> It seems a bit odd to allow use of C++11 features and yet still use C90 for
> the rest of the codebase. I realize the C++ code is largely limited to
> interfaces with lower-level libraries and bindings, but I would lean toward
> C++98, at least initially. (That is, unless you've got a compelling reason
> for rvalue references. :P )
The only reason for trying for C++11 is, as far as I'm concerned,
getting std::shared_ptr <memory>. The C++ bindings I'm slowly wrapping
my head around will need it, and I don't want to even consider using
standard containers without it. The only alternative to C++11 is using
Boost, and that's a last resort grabbing for straws, as far as I'm
concerned.
-- Brane
P.S.: Nothing wrong with Boost as such, of course; but including
<boost/shared_ptr.hpp> tends to pull in some 90% of Boost's headers, and
I consider that overkill.
--
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com
Received on 2012-12-14 04:22:13 CET