Philip Martin wrote:
> Julian Foad <julianfoad_at_btopenworld.com> writes:
>> The mod_dav_svn replay report was logging the entire session
>> URL in the httpd access log. Make it do what it is supposed
>> to do, which is log just the path-within-repos.
>
> The logging is really just a side-effect. We setup this structure in
> several places and set the path member to a path. In one place we put a
> full URL in by mistake. As far as I can tell the member is supposed to
> be a path and the URL is wrong. The fact that this field appears in a
> log file simply makes the error visible. The error is that the field
> contains an URL when it should contain a path.
Great, thanks - that's the level of understanding I was looking for. I would have got that if the log message said something like,
[[[
Fix a bug whereby, during a 'replay' using Serf, a URL was being
sent to the server instead of a path. The only effect we know of
is that the entire session URL was written to the httpd access log.
* subversion/libsvn_ra_serf/replay.c
(svn_ra_serf__replay, svn_ra_serf__replay_range): Initialize the
handler's 'path' field to the request path portion of the URL,
not to the full session URL.
]]]
Does that reflect it correctly?
- Julian
Received on 2012-12-07 17:32:13 CET