[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Replay report logs the entire session url in httpd access log

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 07 Dec 2012 16:10:36 +0000

Philip Martin <philip.martin_at_wandisco.com> writes:

> Julian Foad <julianfoad_at_btopenworld.com> writes:
>
>>   The mod_dav_svn replay report was logging the entire session
>>   URL in the httpd access log.  Make it do what it is supposed
>>   to do, which is log just the path-within-repos.
>
> The logging is really just a side-effect. We setup this structure in
> several places and set the path member to a path. In one place we put a
> full URL in by mistake. As far as I can tell the member is supposed to
> be a path and the URL is wrong. The fact that this field appears in a
> log file simply makes the error visible. The error is that the field
> contains an URL when it should contain a path.

I changed the log to:

* subversion/libsvn_ra_serf/replay.c
  (svn_ra_serf__replay, svn_ra_serf__replay_range): Use a request path,
   rather than a full URL, where a path is expected. This bug showed
   up as a full URL in the httpd access log.

Patch by: Vijayaguru G <vijay{_AT_}collab.net>

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2012-12-07 17:11:14 CET

This is an archived mail posted to the Subversion Dev mailing list.