[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1416494 - /subversion/branches/1.7.x/STATUS

From: Bert Huijben <bert_at_qqmail.nl>
Date: Mon, 3 Dec 2012 13:51:20 +0100

> -----Original Message-----
> From: rhuijben_at_apache.org [mailto:rhuijben_at_apache.org]
> Sent: maandag 3 december 2012 13:46
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1416494 - /subversion/branches/1.7.x/STATUS
>
> Author: rhuijben
> Date: Mon Dec 3 12:46:08 2012
> New Revision: 1416494
>
> URL: http://svn.apache.org/viewvc?rev=1416494&view=rev
> Log:
> * STATUS: Cast some votes, approving r1407597 which the bot can't merge.

* r1409804
Add a delimiter between the two chains in svn_error_compose_create().
Justification:
> misrepresentation that the first error is caused by the second.
> Votes:
> +1: danielsh
> + -0: rhuijben (I'm not sure if this should be in a patch release and the
> + stacktrace where this refers to is maintainer only)

Note that this patch just adds the _("Additional errors:") when using svn_error_compose_create() while in many cases we just pass err to svn_error_createf(), even though it isn't really an error cause.
(Some examples are closing files, resetting sqlite statements, etc.)

I don't think we should apply this change as it just changes the expectations of users.

In some cases the second error might even be the root cause. (I usually position the most important error first, but that doesn't make it the root cause)

        Bert
Received on 2012-12-03 13:52:02 CET

This is an archived mail posted to the Subversion Dev mailing list.