[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Implement '--include-externals' option to 'svn list'

From: vijay <vijay_at_collab.net>
Date: Mon, 26 Nov 2012 12:14:42 +0530

On Tuesday 13 November 2012 03:02 AM, Stefan Sperling wrote:
>> Attached the updated patch and log message.
>
>> + /* Notify that we're about to handle an external. */
>> + SVN_ERR(list_func(baton, NULL, NULL, NULL, NULL,
>> + externals_parent_url,
>> + item->target_dir, iterpool));
>
> The docstring of svn_client_list_func2_t doesn't say if it is valid
> for path or dirent to be NULL.
>
> However, you're passing NULL for these parameters before listing the
> external. Do we really need these two extra list_func() calls before
> and after listing the external? I was expecting them to go away.
>

The two extra list_func() calls has gone away!

Attaching the updated patch that addresses your review comments.

Thanks & Regards,
Vijayaguru

Received on 2012-11-26 07:45:33 CET

This is an archived mail posted to the Subversion Dev mailing list.