[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1413482 - /subversion/trunk/subversion/libsvn_subr/string.c

From: Branko Čibej <brane_at_wandisco.com>
Date: Mon, 26 Nov 2012 06:34:58 +0100

On 26.11.2012 06:27, brane_at_apache.org wrote:
> Author: brane
> Date: Mon Nov 26 05:27:20 2012
> New Revision: 1413482
>
> URL: http://svn.apache.org/viewvc?rev=1413482&view=rev
> Log:
> Factor the svn_stringbuf_t and svn_membuf_t implementation to a common code base.
>
> * subversion/libsvn_subr/string.c (membuf_create, membuf_ensure): New, private
> helper functions for membufs and stringbufs.
> (svn_membuf__create): Call membuf_create.
> (svn_membuf__ensure): Call membuf_ensure.
> (svn_membuf__resize): Call membuf_ensure for resizing the buffer.
> (my__realloc): Remove.
> (create_stringbuf): Remove. Inline implementation into the single call.
> (svn_stringbuf_createv): Inline the previous contents of create_stringbuf.
> (svn_stringbuf_create_ensure): Call membuf_create to allocate the buffer.
> (svn_stringbuf_ensure): Call membuf_ensure to resize the buffer.
>
> Modified:
> subversion/trunk/subversion/libsvn_subr/string.c

I wouldn't mind having another pair of eyes take a look at this.

-- Brane

-- 
Branko Čibej
Director of Subversion | WANdisco | www.wandisco.com
Received on 2012-11-26 06:35:38 CET

This is an archived mail posted to the Subversion Dev mailing list.