[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC] svn propset should require 'force' to set unknown svn: propnames

From: Mark Phippard <markphip_at_gmail.com>
Date: Fri, 23 Nov 2012 11:17:46 -0500

On Fri, Nov 23, 2012 at 5:43 AM, Branko Čibej <brane_at_wandisco.com> wrote:
> On 19.11.2012 03:50, Julian Foad wrote:
>> Proposal:
>>
>> For any unrecognized property name in the 'svn:' name space, these would bail out with an error unless '--force' is given:
>>
>> svn pset svn:foo
>> svn pedit svn:foo
>>
>> and all other subcommands where properties are handled would continue to work as normal, no '--force' needed
>
> Here's what the prototype currently does. Any suggestions for better
> wording are most welcome.
>
> $ svn ps svm:ignore x .
> svn: E195011: 'svm:ignore' is not a valid svn: property name; did you mean 'svn:ignore'?
> (Use --force if you're sure about 'svm:ignore'.)
>
> $ svn ps gvm:ignore x .
> property 'gvm:ignore' set on '.'
>
> $ svn ps gvn:ignore x .
> svn: E195011: 'gvn:ignore' is not a valid svn: property name; did you mean 'svn:ignore'?
> (Use --force if you're sure about 'gvn:ignore'.)
>
> $ svn ps svn:ignores x .
> svn: E195011: 'svn:ignores' is not a valid svn: property name; did you mean 'svn:ignore'?
> (Use --force if you're sure about 'svn:ignores'.)
>
> $ svn ps svn:local-ignore x .
> svn: E195011: 'svn:local-ignore' is not a valid svn: property name; did you mean 'svn:global-ignores'?
> (Use --force if you're sure about 'svn:local-ignore'.)

Personally, I think checking for mis-spellings in "svn:" goes too far.
 For example, do these checks interfere with setting any of the tsvn:
properties? I would be very much against that as they are widely
used. Your example shows blocking gvn:ignore. AFAIK, the gvn project
is not being used since Google decided not to use SVN, but what if
they had? Would we really want to require --force for properties
named gvn:*?

http://code.google.com/p/gvn/

It is difficult to say because I can see the value in what you are
doing here. It just seems like it is walking us down a path that we
typically try to stay away from.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
Received on 2012-11-23 17:18:20 CET

This is an archived mail posted to the Subversion Dev mailing list.