[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1412911 - in /subversion/trunk: subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_repos/reporter.c tools/client-side/svn-bench/null-log-cmd.c tools/server-side/fsfs-reorg.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Fri, 23 Nov 2012 16:10:58 +0000

I can easily make these cases a compile error with Visual C++, but that
will probably make other developers call it a broken/old/(fill in your own
curse word) compiler for following such an old standard.

Suggestions?

Bert

 *From:* julianfoad_at_apache.org
*Sent:* November 23, 2012 4:19 PM
*To:* commits_at_subversion.apache.org
*Subject:* svn commit: r1412911 - in /subversion/trunk:
subversion/libsvn_fs_fs/fs_fs.c subversion/libsvn_repos/reporter.c
tools/client-side/svn-bench/null-log-cmd.c tools/server-side/fsfs-reorg.c

Author: julianfoad
Date: Fri Nov 23 15:18:48 2012
New Revision: 1412911

URL: http://svn.apache.org/viewvc?rev=1412911&view=rev
Log:
Do not use non-constant initializers in struct variables, since this
violates our C'89 coding standard. Although most compilers used for
Subversion support non-constant initializers, some do not, such as Solaris
SunPRO. Note that GCC requires the '-pedantic' option to report this.

A previous commit of this kind was r1352068.
Received on 2012-11-23 17:11:35 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.