[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1408849 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 13 Nov 2012 14:33:09 -0500

On 11/13/2012 02:21 PM, Stefan Sperling wrote:
> On Tue, Nov 13, 2012 at 05:32:00PM -0000, cmpilato_at_apache.org wrote:
>> Author: cmpilato
>> Date: Tue Nov 13 17:31:59 2012
>> New Revision: 1408849
>>
>> URL: http://svn.apache.org/viewvc?rev=1408849&view=rev
>> Log:
>> * subversion/libsvn_ra_serf/update.c
>> (end_report): Remove redundant boolean assignment ("if (X) { X = TRUE }").
>
> Are you sure this is not a bug checking the wrong X or setting the wrong
> X to TRUE? I don't know ra_serf very well so this isn't obvious to me.

I'm pretty sure it was a bit of accidental fallout from some code
reworking/refactoring I did back when I was working on teaching ra_serf to
ask mod_dav_svn to include all properties in the main REPORT response.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-11-13 20:33:45 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.