[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1408849 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Tue, 13 Nov 2012 20:21:18 +0100

On Tue, Nov 13, 2012 at 05:32:00PM -0000, cmpilato_at_apache.org wrote:
> Author: cmpilato
> Date: Tue Nov 13 17:31:59 2012
> New Revision: 1408849
>
> URL: http://svn.apache.org/viewvc?rev=1408849&view=rev
> Log:
> * subversion/libsvn_ra_serf/update.c
> (end_report): Remove redundant boolean assignment ("if (X) { X = TRUE }").

Are you sure this is not a bug checking the wrong X or setting the wrong
X to TRUE? I don't know ra_serf very well so this isn't obvious to me.

> @@ -1969,9 +1969,6 @@ end_report(svn_ra_serf__xml_parser_t *pa
> */
> if (info->dir->fetch_props)
> {
> - /* Unconditionally set fetch_props now. */
> - info->dir->fetch_props = TRUE;
> -
Received on 2012-11-13 20:22:16 CET

This is an archived mail posted to the Subversion Dev mailing list.