[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: Encoding fix mailer.py

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 13 Nov 2012 08:57:10 -0500

On 11/13/2012 03:19 AM, Igor Galić wrote:
>>>
>>> Igor, I took a look at your patch. I was confused by one aspect:
>>> why split
>>> the from_addr into words an encode each one individually, rather
>>> than
>>> encoding the whole header value like we do for the Subject: header?
>>> I dug
>>> around in the related RFCs, and if I'm reading the RFCs correctly,
>>> doing
>>> per-word encoding is actually the right thing to do. Should we,
>>> then, do
>>> the same for the Subject: header?
>>
>> Attaching my current modification of your original patch.
>
> My python-fu hasn't really improved since then, but looking at
> your code it looks as though you're not importing email.Header
> in a loop at least ;)

True. But ... uh ... any response on the more meaningful questions I asked
of you in this thread?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-11-13 14:57:46 CET

This is an archived mail posted to the Subversion Dev mailing list.