[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]: Encoding fix mailer.py

From: Igor Galić <i.galic_at_brainsware.org>
Date: Tue, 13 Nov 2012 08:19:55 +0000 (UTC)

> >
> > Igor, I took a look at your patch. I was confused by one aspect:
> > why split
> > the from_addr into words an encode each one individually, rather
> > than
> > encoding the whole header value like we do for the Subject: header?
> > I dug
> > around in the related RFCs, and if I'm reading the RFCs correctly,
> > doing
> > per-word encoding is actually the right thing to do. Should we,
> > then, do
> > the same for the Subject: header?
>
> Attaching my current modification of your original patch.

My python-fu hasn't really improved since then, but looking at
your code it looks as though you're not importing email.Header
in a loop at least ;)

> --
> C. Michael Pilato <cmpilato_at_collab.net>
> CollabNet <> www.collab.net <> Enterprise Cloud Development
>

-- 
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic_at_brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE
Received on 2012-11-13 09:20:32 CET

This is an archived mail posted to the Subversion Dev mailing list.