On Sun, Sep 23, 2012 at 8:41 PM, Bert Huijben <bert_at_qqmail.nl> wrote:
>
>
>> -----Original Message-----
>> From: lgo_at_apache.org [mailto:lgo_at_apache.org]
>> Sent: zondag 23 september 2012 01:03
>> To: commits_at_subversion.apache.org
>> Subject: svn commit: r1388975 -
>> /subversion/trunk/subversion/libsvn_ra_serf/util.c
>>
>> Author: lgo
>> Date: Sun Sep 23 08:02:58 2012
>> New Revision: 1388975
>>
>> URL: http://svn.apache.org/viewvc?rev=1388975&view=rev
>> Log:
>> Partial fix for issue #4174.
>>
>> * subversion/libsvn_ra_serf/util.c:
>> (handle_response): Connection abort is now an error where serf can
>> recover
>> from, so treat it as non-fatal error.
>
> I think this check should be part of a serf macro/function as we shouldn't keep updating ra_serf whenever serf changes its error handling.
> (Shouldn't these be caught by the bucket read error macro?)
>
> The model where error codes can be either subversion errors from a callback or serf errors that should be passed up the chain isn't that clean.
>
Yes, I plan to add a new macro to check for non-fatal errors during
response handling. But this will only be available from the next serf
release on so I decided to fix it directly on svn trunk first.
Lieven
[..]
Received on 2012-09-23 20:48:12 CEST