> -----Original Message-----
> From: lgo_at_apache.org [mailto:lgo_at_apache.org]
> Sent: zondag 23 september 2012 01:03
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1388975 -
> /subversion/trunk/subversion/libsvn_ra_serf/util.c
>
> Author: lgo
> Date: Sun Sep 23 08:02:58 2012
> New Revision: 1388975
>
> URL: http://svn.apache.org/viewvc?rev=1388975&view=rev
> Log:
> Partial fix for issue #4174.
>
> * subversion/libsvn_ra_serf/util.c:
> (handle_response): Connection abort is now an error where serf can
> recover
> from, so treat it as non-fatal error.
I think this check should be part of a serf macro/function as we shouldn't keep updating ra_serf whenever serf changes its error handling.
(Shouldn't these be caught by the bucket read error macro?)
The model where error codes can be either subversion errors from a callback or serf errors that should be passed up the chain isn't that clean.
Bert
>
> Modified:
> subversion/trunk/subversion/libsvn_ra_serf/util.c
>
> Modified: subversion/trunk/subversion/libsvn_ra_serf/util.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/
> util.c?rev=1388975&r1=1388974&r2=1388975&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/libsvn_ra_serf/util.c (original)
> +++ subversion/trunk/subversion/libsvn_ra_serf/util.c Sun Sep 23 08:02:58
> 2012
> @@ -1986,7 +1986,8 @@ handle_response(serf_request_t *request,
>
> if (err
> && (!SERF_BUCKET_READ_ERROR(err->apr_err)
> - || APR_STATUS_IS_ECONNRESET(err->apr_err)))
> + || APR_STATUS_IS_ECONNRESET(err->apr_err)
> + || APR_STATUS_IS_ECONNABORTED(err->apr_err)))
> {
> /* These errors are special cased in serf
> ### We hope no handler returns these by accident. */
>
Received on 2012-09-23 20:42:12 CEST