[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1383480 - in /subversion/trunk/subversion: svn/cl.h svn/log-cmd.c svn/main.c tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout tests/cmdline/log_tests.py

From: Branko Čibej <brane_at_wandisco.com>
Date: Fri, 21 Sep 2012 11:10:57 +0200

On 21.09.2012 11:07, Stefan Sperling wrote:
> On Fri, Sep 21, 2012 at 09:37:32AM +0100, Daniel Shahaf wrote:
>> Stefan Sperling wrote on Fri, Sep 21, 2012 at 10:07:13 +0200:
>>> Overall, I like all of your suggestions, but I don't see a need for
>>> us to implement them all for 1.8. In my mind, these are nice bite-size
>>> tasks for our issue tracker that new contributors could pick up.
>>> So I'd suggest filing a "bite-sized" issue for each of the above.
>> Disagree. The big problem is compatibility: once you have
>> --search --isearch --search-and --isearch-and
>> you have committed to that particular UI. Let's figure out a UI _now_
>> that can stand all the extensions discussed (case-insensitive,
>> logical and/or/not, regexes, etc).
> Geez, the perfect is the enemy of the good.
>
> As for regex support, well, I'm not gonna do the heavy lifting
> of integrating a regex engine into our code base for 1.8.
>
> Really, I implemented this search stuff for simple things like
> filtering log messages on stuff like 'Patch by', not to implement
> my own google for revprops.

Is doing this in the log receiver really any faster than filtering in a
custom callback handler, or even a script? Granted that filtering logs
server-side would save network bandwidth and turnarounds.

-- Brane

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
Received on 2012-09-21 11:11:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.