Re: svn commit: r1383480 - in /subversion/trunk/subversion: svn/cl.h svn/log-cmd.c svn/main.c tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout tests/cmdline/log_tests.py

On Fri, Sep 21, 2012 at 09:37:32AM +0100, Daniel Shahaf wrote:
> Stefan Sperling wrote on Fri, Sep 21, 2012 at 10:07:13 +0200:
> > Overall, I like all of your suggestions, but I don't see a need for
> > us to implement them all for 1.8. In my mind, these are nice bite-size
> > tasks for our issue tracker that new contributors could pick up.
> > So I'd suggest filing a "bite-sized" issue for each of the above.
>
> Disagree. The big problem is compatibility: once you have
> --search --isearch --search-and --isearch-and
> you have committed to that particular UI. Let's figure out a UI _now_
> that can stand all the extensions discussed (case-insensitive,
> logical and/or/not, regexes, etc).

Geez, the perfect is the enemy of the good.

As for regex support, well, I'm not gonna do the heavy lifting
of integrating a regex engine into our code base for 1.8.

Really, I implemented this search stuff for simple things like
filtering log messages on stuff like 'Patch by', not to implement
my own google for revprops.

That aside, don't you like the option names I suggested in response
to Julian's ideas? I think that UI is fine, and it's something
we can indeed add at a later stage.
Received on 2012-09-21 11:07:56 CEST