Re: svn commit: r1381766 - /subversion/trunk/subversion/libsvn_subr/utf_validate.c

On Fri, Sep 7, 2012 at 7:19 PM, Peter Samuelson <peter_at_p12n.org> wrote:

>
> [stefan2_at_apache.org]
> > + for (; len > 0; ++data, --len)
> > + if (*data < 0)
> > + return data;
>
> Two major problems:
>
> 1) It doesn't account for character sets like Shift-JIS, where state
> change is signalled by ASCII 14 and 15 ("shift out", "shift in")
>

Red herring caused by sloppy language use on my side.

> 2) It assumes a 'char' is signed by default. This is not true on all
> platforms.
>

Addressed in r1382204 as well.

-- Stefan^2.

-- 
*
Join us this October at Subversion Live
2012<http://www.wandisco.com/svn-live-2012>
 for two days of best practice SVN training, networking, live demos,
committer meet and greet, and more! Space is limited, so get signed up
today<http://www.wandisco.com/svn-live-2012>
!
*