Re: svn commit: r1381766 - /subversion/trunk/subversion/libsvn_subr/utf_validate.c

On Fri, Sep 7, 2012 at 6:18 PM, Branko Čibej <brane_at_wandisco.com> wrote:

> On 06.09.2012 23:30, stefan2_at_apache.org wrote:
> > Author: stefan2
> > Date: Thu Sep 6 21:30:40 2012
> > New Revision: 1381766
> >
> > URL: http://svn.apache.org/viewvc?rev=1381766&view=rev
> > Log:
> > Many strings we need to convert to UTF-8 (paths, even log messages)
> > contain large ASCII chars only sections. Add utility functions
> > to very efficiently skip those sections at the begin of the strings.
>
> Um. You are aware, of course, that by doing this without any knowledge
> of the string encoding, you could easily be skipping encoded code
> points. In other words, the concept is wrong.
>
>
Sloppy language. This is UTF-8 only handling -
which is uniformly defined everywhere (and our
code assumes just that also in other places).

r1382204 should eliminate that confusion.

-- Stefan^2.

-- 
*
Join us this October at Subversion Live
2012<http://www.wandisco.com/svn-live-2012>
 for two days of best practice SVN training, networking, live demos,
committer meet and greet, and more! Space is limited, so get signed up
today<http://www.wandisco.com/svn-live-2012>
!
*