RE: svn commit: r1375675 - in /subversion/trunk/subversion: include/svn_repos.h libsvn_repos/fs-wrap.c libsvn_repos/hooks.c libsvn_repos/repos.c libsvn_repos/repos.h tests/cmdline/commit_tests.py tests/cmdline/svntest/actions.py

> -----Original Message-----
> From: cmpilato_at_apache.org [mailto:cmpilato_at_apache.org]
> Sent: dinsdag 21 augustus 2012 19:30
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1375675 - in /subversion/trunk/subversion:
> include/svn_repos.h libsvn_repos/fs-wrap.c libsvn_repos/hooks.c
> libsvn_repos/repos.c libsvn_repos/repos.h tests/cmdline/commit_tests.py
> tests/cmdline/svntest/actions.py
>
> Author: cmpilato
> Date: Tue Aug 21 17:29:40 2012
> New Revision: 1375675
>
> URL: http://svn.apache.org/viewvc?rev=1375675&view=rev
> Log:
> Introduce a new 'init-commit' hook script which runs immediately after
> the commit txn is created and populated with initial txnprops.

This is more about your previous patches:

When is this script run when committing with a non http-v2 dav client?

Are the txnprops available then? Or just with the other ra layers and new dav clients?

<snip>

> +svn_error_t *
> +svn_repos__hooks_init_commit(svn_repos_t *repos,
> + const char *txn_name,
> + apr_pool_t *pool)
> +{
> + const char *hook = svn_repos_init_commit_hook(repos, pool);
> + svn_boolean_t broken_link;
> +
> + if ((hook = check_hook_cmd(hook, &broken_link, pool)) && broken_link)
> + {
> + return hook_symlink_error(hook);
> + }
> + else if (hook)
> + {
> + const char *args[4];
> +
> + args[0] = hook;
> + args[1] = svn_dirent_local_style(svn_repos_path(repos, pool), pool);
> + args[2] = txn_name;
> + args[3] = NULL;

Should we also pass the user here?

We pass it for at least some of the other hooks and I'm not sure if it is guaranteed always to be the same as the one stored in the transaction properties.

        Bert
Received on 2012-08-21 20:03:27 CEST