[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issues building svn 1.7.6 in non apache mode (module mod_dontdothat) [and unrelated 'make check' clarification]

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 20 Aug 2012 17:19:43 +0100

Daniel Shahaf wrote on Mon, Aug 20, 2012 at 16:50:11 +0100:
> Bob Chapman wrote on Mon, Aug 20, 2012 at 10:32:01 -0500:
> > Daniel -
> >
> > > Check 'make -n install | grep dontdothat'.
> >
> > In the 'patched' 1.7.6 version:
> >
> > $ make -n install | grep dontdothat
> > $
> >
>
> That's the expected/bug-free output.
>
> > > (There is a longer answer telling you about . . .
> >
> > Which I'm probably not smart enough to understand. <grin>
> >
> > It didn't cross my mind to run 'make check' until _after_ my previous
> > post -- someday I may learn to think twice before posting. ;(
> >
> > On Unbuntu 10.04 LTS, the 87/87 'success' reports looked good but I
> > haven't figured out what to make of the subsequent string of 'SKIP' and
> > 'X-FAIL' messages or the summary:
> >
> > Summary of test results:
> > 1583 tests PASSED
> > 46 tests SKIPPED
> > 22 tests XFAILED (1 WORK-IN-PROGRESS)
> >
>
> That's "ALL TESTS SUCCESSFUL".
>
> Maybe we should print a one-bit summary like that at the end of the run?
>

r1375089.

> % svn di -x-p build/run_tests.py
> Index: build/run_tests.py
> ===================================================================
> --- build/run_tests.py (revision 1349313)
> +++ build/run_tests.py (working copy)
> @@ -316,6 +316,12 @@ class TestHarness:
> print("WARNING: no failures, but '%s' exists from a previous run."
> % self.faillogfile)
>
> + # Summary.
> + if xpassed or failed_list:
> + print("SUMMARY: All tests successful\n")
> + else:
> + print("SUMMARY: Some tests failed.\n")
> +
> self._close_log()
> return failed
Received on 2012-08-20 18:20:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.