Re: svn commit: r1369183 - /subversion/trunk/subversion/libsvn_subr/debug.c

On Aug 3, 2012 5:01 PM, "Julian Foad" <julianfoad_at_btopenworld.com> wrote:
>
> Greg Stein wrote:
>
> > On Fri, Aug 3, 2012 at 3:49 PM, <julianfoad_at_apache.org> wrote:
> >> ...
> >> * subversion/libsvn_subr/debug.c
> >> (debug_pool, debug_file, debug_line): New variables.
> >> (svn_dbg__preamble): Create a pool, the first time we're called.
Just
> >> store the prefix information instead of printing it. (Note: this
> >> isn't thread-safe; it already wasn't.)
> >
> > Please don't use a pool. Then you get into issues about how large it
> > may grow. Just snprintf() into a 1k stack-based buffer.
>
> snprintf/vsnprintf isn't in C'89.

There is an APR version of that, I believe.

>
> Use it anyway, or perhaps clear the pool after using it instead?

I thought about clearing the pool, but that could crash when threads are
present.

Cheers,
-g
Received on 2012-08-03 23:07:31 CEST