[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1369183 - /subversion/trunk/subversion/libsvn_subr/debug.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Fri, 3 Aug 2012 22:01:02 +0100 (BST)

Greg Stein wrote:

> On Fri, Aug 3, 2012 at 3:49 PM,  <julianfoad_at_apache.org> wrote:
>> ...
>> * subversion/libsvn_subr/debug.c
>>   (debug_pool, debug_file, debug_line): New variables.
>>   (svn_dbg__preamble): Create a pool, the first time we're called. Just
>>     store the prefix information instead of printing it. (Note: this
>>     isn't thread-safe; it already wasn't.)
>
> Please don't use a pool. Then you get into issues about how large it
> may grow. Just snprintf() into a 1k stack-based buffer.

snprintf/vsnprintf isn't in C'89.

Use it anyway, or perhaps clear the pool after using it instead?

- Julian
Received on 2012-08-03 23:01:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.