[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1352044 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 20 Jun 2012 19:05:33 +0200

On Wed, Jun 20, 2012 at 07:12:43AM -0400, Greg Stein wrote:
> Stefan: this should fix your "cat" problem. If the server is old, then
> it reports the property as missing. We don't examine the specific
> status results (tho we should, but then again: we don't talk to any
> servers but our own), so we just see <S:sha1-checksum/> where it names
> the property that was missing.
>
> Basically: a backwards-compat bug where we failed to work against old
> servers. Fixed. (and no, I won't point fingers at Ivan... oh. oops.
> :-P )

Thanks! I did try to debug this last night, and also found that the
sha1 checksum was an empty string. I wasn't sure though wether we could
treat NULL and the empty string equivalently. I believe I've seen code
where NULL indicates properly deletion, but an empty string just sets the
property to an empty value. Does this idiom not apply to ra_serf?
Received on 2012-06-20 19:06:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.