Stefan: this should fix your "cat" problem. If the server is old, then
it reports the property as missing. We don't examine the specific
status results (tho we should, but then again: we don't talk to any
servers but our own), so we just see <S:sha1-checksum/> where it names
the property that was missing.
Basically: a backwards-compat bug where we failed to work against old
servers. Fixed. (and no, I won't point fingers at Ivan... oh. oops.
:-P )
Cheers,
-g
On Wed, Jun 20, 2012 at 7:08 AM, <gstein_at_apache.org> wrote:
> Author: gstein
> Date: Wed Jun 20 11:08:45 2012
> New Revision: 1352044
>
> URL: http://svn.apache.org/viewvc?rev=1352044&view=rev
> Log:
> Followup to r1350584: a missing sha1-checksum property can also be the
> empty string (e.g. <S:sha1-checksum/>)
>
> * subversion/libsvn_ra_serf/update.c:
> (try_get_wc_contents): look for both missing and empty string on the
> sha1-checksum property
>
> Modified:
> subversion/trunk/subversion/libsvn_ra_serf/update.c
>
> Modified: subversion/trunk/subversion/libsvn_ra_serf/update.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/update.c?rev=1352044&r1=1352043&r2=1352044&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_ra_serf/update.c (original)
> +++ subversion/trunk/subversion/libsvn_ra_serf/update.c Wed Jun 20 11:08:45 2012
> @@ -2874,9 +2874,9 @@ try_get_wc_contents(svn_boolean_t *found
>
> sha1_checksum_prop = svn_prop_get_value(svn_props, "sha1-checksum");
>
> - if (!sha1_checksum_prop)
> + if (sha1_checksum_prop == NULL || *sha1_checksum_prop == '\0')
> {
> - /* No checksum property in response. */
> + /* No checksum property in response (missing or empty string). */
> return SVN_NO_ERROR;
> }
>
>
>
Received on 2012-06-20 13:13:20 CEST