[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch to remove libsvn_ra_neon

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Wed, 13 Jun 2012 10:02:03 +0200

On Wed, Jun 13, 2012 at 9:33 AM, Greg Stein <gstein_at_gmail.com> wrote:
> On Tue, Jun 12, 2012 at 7:47 AM, Hyrum K Wright
> <hyrum.wright_at_wandisco.com> wrote:
>> We've had the "should we remove neon?" discussion before, and the
>> consensus has felt to resolve in the affirmative.  Now is the time for
>> action.
>>
>> I've got a 586 kb patch which removes libsvn_ra_neon from trunk.  It
>> doesn't not remove the --http-library runtime option or config file
>> code, but does remove the various build stuff which supports building
>> neon.  I obviously haven't tested this on all platforms, and I
>> wouldn't be surprised if it causes some short-term breakage.  My plan
>> is to commit this patch Real Soon Now, pending any very vocal
>> objections from folks on this list.
>
> Maybe do it as a number of reviewable pieces, rather than one mother patch?

I could do that, but most of the patch is just 'svn rm
subversion/libsvn_ra_neon' and the associated build system cruft:

$ svn diff | diffstat
 Makefile.in | 18
 build.conf | 51
 build/ac-macros/neon.m4 | 169 -
 build/generator/gen_msvc_dsp.py | 1
 build/generator/gen_vcnet_vcproj.py | 1
 build/generator/gen_win.py | 99
 build/generator/templates/neon.dsp.ezt | 96
 build/generator/templates/neon.vcproj.ezt | 85
 build/generator/templates/neon.vcxproj.ezt | 64
 build/win32/make_dist.py | 6
 build/win32/vc6-build.bat.in | 4
 configure.ac | 49
 subversion/libsvn_client/repos_diff.c | 7
 subversion/libsvn_ra/ra_loader.c | 29
 subversion/libsvn_ra_neon/README | 112
 subversion/libsvn_ra_neon/commit.c | 1637 ------------
 subversion/libsvn_ra_neon/fetch.c | 2825 ----------------------
 subversion/libsvn_ra_neon/file_revs.c | 388 ---
 subversion/libsvn_ra_neon/get_dated_rev.c | 169 -
 subversion/libsvn_ra_neon/get_deleted_rev.c | 173 -
 subversion/libsvn_ra_neon/get_location_segments.c | 216 -
 subversion/libsvn_ra_neon/get_locations.c | 195 -
 subversion/libsvn_ra_neon/get_locks.c | 438 ---
 subversion/libsvn_ra_neon/lock.c | 609 ----
 subversion/libsvn_ra_neon/log.c | 572 ----
 subversion/libsvn_ra_neon/merge.c | 777 ------
 subversion/libsvn_ra_neon/mergeinfo.c | 255 -
 subversion/libsvn_ra_neon/options.c | 480 ---
 subversion/libsvn_ra_neon/props.c | 1520 -----------
 subversion/libsvn_ra_neon/ra_neon.h | 1199 ---------
 subversion/libsvn_ra_neon/replay.c | 508 ---
 subversion/libsvn_ra_neon/session.c | 1271 ---------
 subversion/libsvn_ra_neon/util.c | 1667 ------------
 33 files changed, 23 insertions(+), 15667 deletions(-)
$

-Hyrum

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2012-06-13 10:02:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.