[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Using svn_hash__make instead of apr_hash__make

From: Stefan Fuhrmann <eqfox_at_web.de>
Date: Sun, 20 May 2012 13:56:32 +0200

Am 20.05.2012 12:14, schrieb Branko Čibej:
> On 20.05.2012 03:33, Greg Stein wrote:
>> I thought the whole reason for variant results was to avoid O(N^2) attacks
>> against the hash table. You would be defeating that work.
>> I see no reason to use a stable hash. If outputs are supposed to stable,
>> then the *presentation * layer should be stabilizing. Not our core data
>> structure.
>> This is the same kind of silliness that stsp made to our core data
>> structures. I still think that should be reverted in favor of presentation
>> changes.
> Couldn't agree more. Especially if the main reason for such changes is
> to make the testsuite work, because then the testsuite should just be
> made order-agnostic instead.
stefan_at_xenon:~/develop/trunk/subversion$ grep -r "apr_hash_make" */*.c |
wc -l

Patches are welcome.

-- Stefan^2.
Received on 2012-05-20 15:57:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.