[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Using svn_hash__make instead of apr_hash__make

From: Branko ─îibej <brane_at_apache.org>
Date: Sun, 20 May 2012 12:14:07 +0200

On 20.05.2012 03:33, Greg Stein wrote:
> I thought the whole reason for variant results was to avoid O(N^2) attacks
> against the hash table. You would be defeating that work.
>
> I see no reason to use a stable hash. If outputs are supposed to stable,
> then the *presentation * layer should be stabilizing. Not our core data
> structure.
>
> This is the same kind of silliness that stsp made to our core data
> structures. I still think that should be reverted in favor of presentation
> changes.

Couldn't agree more. Especially if the main reason for such changes is
to make the testsuite work, because then the testsuite should just be
made order-agnostic instead.

-- Brane
Received on 2012-05-20 12:14:16 CEST

This is an archived mail posted to the Subversion Dev mailing list.