[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bug in can_modify()

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Thu, 17 May 2012 12:04:48 -0500

On Thu, May 17, 2012 at 11:00 AM, Greg Stein <gstein_at_gmail.com> wrote:
>
> On May 17, 2012 11:53 AM, "Hyrum K Wright" <hyrum.wright_at_wandisco.com>
> wrote:
>>
>> On Wed, May 16, 2012 at 11:27 PM, Greg Stein <gstein_at_gmail.com> wrote:
>>...
>
>> > Right. The add/copy should fail because the node already exists. I
>> > relied on
>> > that failure, rather than issuing an OOD. We could add that empty-target
>> > verification.
>>
>> I think we should.  The add/copy isn't failing at all in it's current
>> state, which means some check isn't happening as we expect it to.  I
>> think the OOD check is the reasonable place for this failure (and the
>> tests seem to indicate it's what we've historically done).
>>...
>
>> > Sure. When REPLACES_REV is INVALID, we can call check_path and verify
>> > nothing exists.
>> >
>> > Seem about right?
>>
>> Sounds reasonable.
>
> Go for it, if you like. Otherwise, I'll get to it tonite or so.
>
> I got my Ev2 branch going last night, and got about 20 failures. Does that
> sound right?

Over ra_local, I only see the following 3 failures:
FAIL: blame_tests.py 7: blame with different eol styles
FAIL: tree_conflict_tests.py 4: up/sw file: add onto add
FAIL: tree_conflict_tests.py 8: up/sw dir: add onto add

I haven't run it over ra_serf or ra_svn.

-Hyrum

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2012-05-17 19:05:21 CEST

This is an archived mail posted to the Subversion Dev mailing list.