[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bug in can_modify()

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 17 May 2012 12:00:58 -0400

On May 17, 2012 11:53 AM, "Hyrum K Wright" <hyrum.wright_at_wandisco.com>
wrote:
>
> On Wed, May 16, 2012 at 11:27 PM, Greg Stein <gstein_at_gmail.com> wrote:
>...
> > Right. The add/copy should fail because the node already exists. I
relied on
> > that failure, rather than issuing an OOD. We could add that empty-target
> > verification.
>
> I think we should. The add/copy isn't failing at all in it's current
> state, which means some check isn't happening as we expect it to. I
> think the OOD check is the reasonable place for this failure (and the
> tests seem to indicate it's what we've historically done).
>...
> > Sure. When REPLACES_REV is INVALID, we can call check_path and verify
> > nothing exists.
> >
> > Seem about right?
>
> Sounds reasonable.

Go for it, if you like. Otherwise, I'll get to it tonite or so.

I got my Ev2 branch going last night, and got about 20 failures. Does that
sound right?

Cheers,
-g
Received on 2012-05-17 18:01:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.