Re: svn commit: r1335639 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

On Tue, May 8, 2012 at 12:56 PM, <cmpilato_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Tue May  8 16:56:42 2012
>...
> +  SVN_ERR(svn_wc__db_pristine_check(&present, wc_ctx->db, wri_abspath,
> +                                    sha1_checksum, scratch_pool));
> +
> +  if (present)
> +    {
> +      get_pristine_lazyopen_baton_t *gpl_baton;
> +
> +      gpl_baton = apr_pcalloc(result_pool, sizeof(*gpl_baton));
> +      gpl_baton->wc_ctx = wc_ctx;
> +      gpl_baton->wri_abspath = wri_abspath;
> +      gpl_baton->sha1_checksum = sha1_checksum;

What are the lifetime guarantees of the parameters? I'm guessing that
WC_CTX can be defined as "must live at least as long as the RA
session" (that you provide the callback to), but that WRI_ABSPATH and
SHA1_CHECKSUM need to be copied into RESULT_POOL.

>...

Great work!

Cheers,
-g
Received on 2012-05-08 20:34:25 CEST