[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1335639 - /subversion/trunk/subversion/libsvn_wc/adm_ops.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Tue, 8 May 2012 12:59:28 -0400

On 05/08/2012 12:56 PM, cmpilato_at_apache.org wrote:
> Author: cmpilato
> Date: Tue May 8 16:56:42 2012
> New Revision: 1335639
>
> URL: http://svn.apache.org/viewvc?rev=1335639&view=rev
> Log:
> Avoid opening pristine store file handles until they are actually
> required.
>
> * subversion/libsvn_wc/adm_ops.c
> (get_pristine_lazyopen_baton_t): New private callback baton type.
> (get_pristine_lazyopen_func): Callback implementation.
> (svn_wc__get_pristine_contents_by_checksum): Use the new lazyopen
> stream mechanics to avoid opening a file handle to the pristine
> contents until it's first really needed.
>
> Suggested by: gstein

Mark, can you see if this (and previous commits I've made) fixes the file
handle abuse problem you reported?

I tested this locally using "ulimit -n 200" to reduce the file handle limit
on my box from 8192 to 200. Before this change, I saw the same error you
did. Afterward, no error. Hoping you experience the same.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Enterprise Cloud Development

Received on 2012-05-08 19:00:28 CEST

This is an archived mail posted to the Subversion Dev mailing list.