[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: APR hash order ruby test failure

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Wed, 28 Mar 2012 13:44:07 +0100

Hyrum K Wright <hyrum.wright_at_wandisco.com> writes:

> On Wed, Mar 28, 2012 at 4:30 AM, Philip Martin
>> We fix these by converting the arrays to sets so that the order is
>> irrelevant.  The open question is whether we do this solely within the
>> testsuite, changing both sides of the comparison, or whether we change
>> the bindings to return a set and adjust the testsuite to match.
> I think that depends on the compatibility guarantees of the bindings.
> Making them a set feels more correct from a semantic perspective, but
> I don't know if it will break existing consumers.

Indeed; Daniel and I discusssed it on IRC. We don't really know what
guarantees apply. We don't know who consumes the Ruby bindings, google
doesn't show much so perhaps it's people writing private stuff. Some
consumers may not even notice an array to set change and would continue
to operate.

uberSVN: Apache Subversion Made Easy
Received on 2012-03-28 14:44:48 CEST

This is an archived mail posted to the Subversion Dev mailing list.