[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1306111 - in /subversion/trunk/subversion: libsvn_ra_svn/client.c svnserve/serve.c

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 28 Mar 2012 05:37:11 -0400

On Mar 28, 2012 4:23 AM, "Daniel Shahaf" <d.s_at_daniel.shahaf.name> wrote:
>
> gstein_at_apache.org wrote on Wed, Mar 28, 2012 at 01:51:54 -0000:
> > Author: gstein
> > Date: Wed Mar 28 01:51:54 2012
> > New Revision: 1306111
> >
> > URL: http://svn.apache.org/viewvc?rev=1306111&view=rev
> > Log:
> > Fix a problem in the svn protocol's get_dir() functionality. The tuple
> > specification allowed for a NULL created-date, but the client would
> > segfault with that input (via svn_time_from_string).
> >
>
> Backport?

For client resilience, sure. But very, very low footprint/issue. IMO, not a
release driver, but something to get caught up into a release.

>
> > - svn_dirent_t entry;
> > - memset(&entry, 0, sizeof(entry));
> > + /* The fields in the entry tuple. */
> > + svn_node_kind_t entry_kind = svn_node_none;
> > + svn_filesize_t entry_size = 0;
> > + svn_boolean_t has_props = FALSE;
> > + svn_revnum_t created_rev = 0; /* ### SVN_INVALID_REVNUM */
> > + const char *cdate = NULL;
> > + const char *last_author = NULL;
>
> Unrelated change.

Right. Agreed. Only client.c is interesting for a backport.

Cheers,
-g
Received on 2012-03-28 11:37:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.