[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: buildbot failure in ASF Buildbot on svn-slik-w2k3-x64-ra

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 28 Mar 2012 09:16:22 +0100 (BST)

Greg Stein wrote:

> I believe that r1306111 fixes this.
>
> Note that the changes in this area have exposed a long-standing bug in
> the svn client's get_dir handling. I've left behind some docco to
> guard future readers/developers.

Hi Greg.  Just a docco tweak:

Index: subversion/svnserve/serve.c
===================================================================
--- subversion/svnserve/serve.c    (revision 1306195)
+++ subversion/svnserve/serve.c    (working copy)
@@ -1565,7 +1565,9 @@ static svn_error_t *get_dir(svn_ra_svn_c
           /* The fields in the entry tuple.  */
           svn_node_kind_t entry_kind = svn_node_none;
           svn_filesize_t entry_size = 0;
           svn_boolean_t has_props = FALSE;
+          /* If 'created rev' was not requested, send 0.  We can't use
+           * SVN_INVALID_REVNUM as the tuple field is not optional. */
+          svn_revnum_t created_rev = 0;
-          svn_revnum_t created_rev = 0; /* ### SVN_INVALID_REVNUM  */
           const char *cdate = NULL;
           const char *last_author = NULL;

Does that correctly capture the point there?

- Julian
Received on 2012-03-28 10:17:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.