[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1305800 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Stefan Sperling <stsp_at_apache.org>
Date: Tue, 27 Mar 2012 19:00:52 +0200

On Tue, Mar 27, 2012 at 12:32:41PM -0400, Greg Stein wrote:
> On Tue, Mar 27, 2012 at 06:00, <stsp_at_apache.org> wrote:
> > Author: stsp
> > Date: Tue Mar 27 10:00:07 2012
> > New Revision: 1305800
> >
> > URL: http://svn.apache.org/viewvc?rev=1305800&view=rev
> > Log:
> > * subversion/libsvn_wc/wc_db.c
> >  (get_info_for_copy): Allow for NULL status parameter. Should have been
> >    part of r1305793.
>
> Woah! The way you implemented this won't work. Those if-branches need
> to be taken, in order to fill out other OUT parameters.
>
> Instead, you need a local status variable fetched from read_info().
> Switch on that. And if STATUS is not NULL, then store the localvar
> into the output.

Ooops. Thanks for catching this. Fixed in r1305903.
Received on 2012-03-27 19:01:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.