[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1304614 - /subversion/trunk/subversion/libsvn_client/merge.c

From: Greg Stein <gstein_at_gmail.com>
Date: Sun, 25 Mar 2012 14:19:13 -0400

On Sun, Mar 25, 2012 at 13:16, Julian Foad <julianfoad_at_btopenworld.com> wrote:
> Greg Stein wrote:
>> julianfoad_at_apache.org wrote:
>>> Change the members of 'merge_source_t' from in-line to pointers.
>>> A follow-up to r1303807.
>> This says what you did, but I don't understand the justification for it. The code seems more complicated now (eg. the create/dup functions).
>>??
>
>
> Good question.† To be honest I was going on intuition here.† The main aim is to make it simple at the point of use; the complexity of the create/dup functions is rather immaterial in comparison.† The *existence* of the 'create' and 'dup' functions would still be useful without this change.
>
> So, we ask, does this change make it easier to use?† Actually it seems to be neither simpler nor more complex.† I can only say, this is fairly new and still in flux.

More pointers mean more allocations and little fiddly bits to connect
together. Embedded structures are easier to initialize.

Cheers,
-g
Received on 2012-03-25 20:19:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.