Re: svn commit: r1303883 - /subversion/trunk/subversion/tests/cmdline/svntest/main.py

On Thu, Mar 22, 2012 at 13:10, C. Michael Pilato <cmpilato_at_collab.net> wrote:
> On 03/22/2012 12:45 PM, gstein_at_apache.org wrote:
>> Author: gstein
>> Date: Thu Mar 22 16:45:30 2012
>> New Revision: 1303883
>>
>> URL: http://svn.apache.org/viewvc?rev=1303883&view=rev
>> Log:
>> Followup to 1303727: use .rstrip() rather than whacking a single '\n'
>> character off the end. This approach can also handle '\r\n'. Trailing
>> whitespace happens to get killed, but no bigg.
>
> You beat me to this change.  But for the sake of precision, why not go ahead
> and use ".rstrip('\r\n')" ?  Is the extra precision just disinteresting in
> this context?

Correct. These are lines that are going into the logger (stdout,
tests.log, whatever). No need for any trailing whitespace.

Cheers,
-g
Received on 2012-03-22 18:51:45 CET