Re: use of SVN_ERR_ASSERT (was: svn commit: r1302682 ...)

On 03/22/2012 01:36 PM, Greg Stein wrote:
> On Thu, Mar 22, 2012 at 13:33, Daniel Shahaf <danielsh_at_elego.de> wrote:
>> Greg Stein wrote on Thu, Mar 22, 2012 at 13:19:41 -0400:
>> ...
>>> Daniel removed one of these ASSERT uses a day or two ago. My
>>> assumption was that he was referring to that, rather than the ###.
>>>
>>
>> Yes, by "these" I referred to to the use of assert(), abort(), and
>> svn_error__malfunction().
>
> Oh, I definitely don't want to see any assert() or abort() calls. With
> you there.
>
> But if you're suggesting that we stop using SVN_ERR_ASSERT(), then
> that is a much larger question. I see no problem using them. "If we
> don't have what we expect, then we've got big problems."

+1.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand